Showing posts with label bug fix. Show all posts
Showing posts with label bug fix. Show all posts

Thursday, November 15, 2007

I'm releasing v3.1.1 today. It's mostly just a couple of bug fixes. One being just a typo of "instert" instead of "insert." Another being that somehow a couple rogue words got into the code for the music issue submission function in the program logs. I think what happened was that I was working on stuff remotely while at work and the keyboard did not release from the remote window when I started typing into something else. Annoying!

Here's the full list of updates:
  • Fixed loading of saved form input data in the music search.
  • Pressing the "load" button in the music search now runs the search as well, preventing the need to click search after clicking load.
  • Change album locations form now has a field for the ID number.
  • Fixed typo in text on program log page.
  • Fixed error in music issue submission from program log.
Now time to start working on the new permissions system...for real! This is going to be a bitch, but I already have the database structure created.

Let's hear it for having to go through every single file in ELCRo line by line.

Wednesday, October 31, 2007

Apparently, when a user clicked on the artist name and was taken to the music search, the page loaded with the fields filled in, but did not actually run the search.

This has been fixed.
There was a bug that caused the loading and saving of form data in the chart submission tool to not work correctly. Because there are two forms on a single page, the data from one would overwrite the other. I updated the code so that it saves them individually.

Friday, September 21, 2007

An error was pointed out to me that occurs when trying to submit an album to a program log that has a '+' in it. This actually affects all things using AJAX and there are a couple other characters as well. It was just never noticed before because if you're not doing something that writes data you don't get an error. It just gets ignored.

The program is in the use of the GET method. When the plus sign isn't escaped, it's treated like a space. I thought I had everything being escaped, but the javascript escape() method does not cover everything. So I switched over to the encodeURIcomponent() method which does cover this.

This is currently only fixed in beta, but I'll port it over soon.

Tuesday, September 18, 2007

I released v3.0.6 last night. Only two minor updates.
  • Fixed the "add synopsis" link in the program logs so that it actually shows up when it's supposed to.
  • Added a button to insert links into bulletin entries.

Friday, September 7, 2007

It turns out that the problems weren't over yesterday when I thought they were. When I got home from work, I found two more tables that were screwed up so I had XFire drop them. Luckily, they were tables that were created and scrapped from use before ELCRo ever went live.

I also was alerted of a bug that was keeping all users with 'dj' level permissions from doing program logs. What a mess that was. It was just an issue with me making a typo in a variable name in an IF statement. Fixed it up last night and released v3.0.2.
  • Stopped time display in program log from adding an additional leading zero and displaying on two lines sometimes.
  • Added college admin tool to menu system.
  • Fixed the display of the colleges in the admin tool.
  • Upped the result limit for program log searches from 100 to 1000.
  • When the active box is unchecked the program clock will no longer update when adding a new entry.
  • Fixed minor error that prevented some non-playlist songs from being added to a program log.
  • Fixed bug that was locking users with 'dj' permissions out of the program log.
I believe that there is now only one log missing from the system as well as I added the others in manually.

Now, time to start work on v3.1!

Thursday, September 6, 2007

Well, less than 24 hours in and I'm already working on the first update to v3.0. I should have v3.0.1 out the door either later today or tomorrow.

I already fixed one bug so far. The menu system still included the insert log function listed. This has now been removed since it is no longer a separate tool.

Other bugs that need to be fixed:
- Somewhere along the line, the admin for the college list got left out of the menu system. I suspect it's been gone since v2.0.
- The college admin tool when opened isn't formatted correctly.
- Searching logs by content does not seem to work correctly.

I'm also going to make the points on home page a link to the points detail.

Monday, September 3, 2007

I had to fix a few little bugs in the feed reading system.

I made it so that malformed feeds will be skipped over instead of the system trying to force them to XML. This was causing some errors with a few feeds (namely, CMJ). I also made it so that if there are no feeds available, an error message is no longer produced on the client side.

Friday, August 31, 2007

Somehow, I found a way to get some serious work done on ELCRo this week.

I got the RSS reader all up and running in the program logs. It's pretty good, I think. It's basic, but it gets the job done. When you click the headline, the line expands to show the whole article and the headline becomes a link to the article. I still don't have a way to collapse the articles yet, but that will come in due time. The articles can be sorted by time or by site, but not all of the sites provide times with their feeds so I made the backend code add a time 24 hours in the past to those articles. Also, weather.com articles always have the time that they were accessed since they are generated on the fly.

Wednesday, while doing my show, I came up with the idea to have the current weather conditions always available when in live mode. This information is pulled from weather.com and displayed in the empty space to the right of the display section's tabs. It was a little annoying to work with because I had to write a script to find the correct article in the feed. If they ever change the subject line, I'll have to update the code. Then I had to get rid of the image and the "For more details..." at the end. I did it very basically since those seem to be static to every post. If they change this, I'll need to update the code as well.

I still can't figure out why the form in the program logs won't clear after you submit it sometimes. It only seems to happen on the log computer at the radio station, so I still think that the computer is just struggling to keep up with all of the scripting. I did fix a bug that I didn't know existed until now. Ampersands were not being escaped as they need to be for the GET method of submitting forms. This was a big problem in the music search and in the program log. It was a simple fix once I figured out that I just needed to add "escape()" to each of the terms. I only put this in for the program logs and the music search so some of the older pages my still have problems.

Some other features that I've added this week are:
  • Got the stats tab up and running in program logs. This will get more stats later, but it's a good start.
  • When using the move albums function, there is now an option to only show albums that have been reviewed. This should make moving albums from the drawer to playlist much easier. I also added the album ID number next to the album name as well.
  • In the DJ details page, I added a stats tab and removed the program log and album reviews tabs. The stats tab shows the numbers of each and clicking the numbers will bring you to the search page with those listed as results.
  • The music search page can now accept search terms via GET so links to searches can be made.
  • I started slowly switching the links for artist names so that they link to the music search page and automatically search for that artist. Linking to the album details page will now be done from the album name and/or ID number.
  • Made location select box in the program log music search an absolute width so that everything is on one line.
Additionally, I also redesigned and renamed the home page. It is now actually called the home page instead of the main menu. The layout is now a three column set up. At the top there is a horizontal bar that displays the old titlebar messages. I may or may not make only the tips messages stay. I haven't decided yet. Below that, going left to right, there is a column with user information, a column with bulletin/blog entries and a column for reviews. The user info section provides the user's name, number of program logs, points, number of album reviews and open issues. Everything except for points are links. The middle section displays the last 15 active bulletin and blog entries posted and the right section displays the last 15 album reviews posted.

All in all, I got a damn lot done over the last couple weeks. I'm thinking that this will probably be the complete feature set for v3.0, but maybe a few minor things will sneak their way in. Mostly, I want to spend the next few days debugging a bit so that by Tuesday when I unveil this, it's as good as it can be. I'd like to make the home page look nice and pretty, but that probably won't happen.

Thursday, August 9, 2007

Apparently, I didn't fix the DIV resizing thing for the stats and news/pa info tabs like I thought I did yesterday.

The issue turned out to be in the javascript file for tabview. It was changing the tabs to be fixed sizes and wouldn't let me override this from anywhere else.
I fixed a bug that caused the end time for a program log to update to a time in the past when adding an entry to the log if the time for the entry is in the past.

The end time only updates with a time that is later than the current end time.
I fixed the leading zero in the time issue after getting home.
I found a few bugs tonight while doing my show with the new program log...

  • Pressing edit on a playlist entry wouldn't invoke the lookup album function necessary to pull the location and list the song as a playlist song. This couldn't be recreated on my laptop though.
  • The 12am hour has a leading zero in front of the hour making it display as "012."
  • When hitting edit for a song after midnight had changed and the day changed, the date field in the time box did not change to the right date.

Wednesday, August 8, 2007

I fixed a bug in the program logs editing function. Apparently, with songs that don't have an ID number entered in, the artist and album name wasn't getting copied over. This was because of an OR in an if statement that should have been an AND.

Seems to be working fine now.
I finally got the news/pa info tab working on the new program logs. it was a stupid error that was causing it to not show any the of the DIVs when I tried switching. Turns out I had an "=" instead of a ":" in the height style tag.

I've also added the tech issues in. It displays all open tech issues.

Friday, July 27, 2007

I think I have log editing fully working! To get the playlist entries to work correctly, I had to figure out how to create simultaneous AJAX requests that don't collide with each other. It actually is really easy to do know that I know how to do it. I'm still not sure how to make multiple requests for the same function at the same time, but for different functions, it's not a problem.

Yay!

Thursday, July 26, 2007

I fixed a couple minor errors this morning...
- If you have the end time set to edit when the log refreshes, it cancels the edit, but then keeps the open edit status variable set to true and locks the user our of making other edits to the header.
- Reset button in the forms didn't reset the clock.
- When not in live mode, the code would still expect the checkbox for the display log when updated function which was only loaded in live mode. Now it loads in all modes, but is only active in live mode.

I also decided to do a program log stats tab to give the user some stats on their show. This will probably get done next week.

I started work on the entry editing. So far I have the time part working so that the clock gets set to the time that the entry was added. This required me to add date get date function to the javascript code to compliment the time one that already existed.

Wednesday, July 25, 2007

To fit some extra stuff in, I made the view options checkboxes into two sections. There is a button that can be used to toggle between which section displays. One section is for sorting and filtering, the other controls what information you can see about each entry.

I also fixed a bug that caused the last tracks/track listing toggle button to not switch back to the show last tracks setting when looking up a new albums.
I think I figured out the problem with the wrong log entries showing up. I'm not sure why it was happening, but I think I figured out where it is and made a simple workaround. We'll see!

Monday, July 23, 2007

I think I may have fixed the issue with the new program logs where sometimes after adding an entry the entries from a random other log show up. I changed the javascript variable that is passed to be a static value defined on the php side of things. I'm hoping that this takes care of the issue, but it's hard to test.